-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixups #6267
Minor fixups #6267
Conversation
set(SRC_FILES | ||
about_dialog.cpp | ||
auto_pause_settings_dialog.cpp | ||
breakpoint_handler.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really looks like a pain in the ass to manage.
Does VS do this automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno, you just add or remove line with source name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering. What's the reason for this change? Was the old implementation faulty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLOB with *.cpp is one of the possible culprits for unnecessary full rebuilds. Keeping file list is just a recommended way of doing this. Also it makes sure that reconfiguration happens on rebuild.
Add get_sint_t.
ea89112
to
227182e
Compare
Moved Atomic.h to util/atomic.hpp List source files in CMakeLists.txt
No description provided.